Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp: Drop checkpoints #9271

Merged
merged 1 commit into from
May 23, 2023
Merged

exp: Drop checkpoints #9271

merged 1 commit into from
May 23, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Mar 29, 2023

Closes #9221
Closes #8750
Closes #8622
Closes #8009
Closes #7381
Closes #6470
Closes #6194

As part of 3.0 release - (see checklist: #7093)

@daavoo daavoo added the A: experiments Related to dvc exp label Mar 29, 2023
@daavoo daavoo self-assigned this Mar 29, 2023
@daavoo daavoo linked an issue Mar 29, 2023 that may be closed by this pull request
@daavoo daavoo force-pushed the 9221-droprevisit-usage-of-checkpoints branch from e00763e to 16d73db Compare March 29, 2023 10:59
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 84.21% and project coverage change: +0.04 🎉

Comparison is base (182728d) 91.15% compared to head (00f2c7d) 91.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9271      +/-   ##
==========================================
+ Coverage   91.15%   91.20%   +0.04%     
==========================================
  Files         475      473       -2     
  Lines       37240    36660     -580     
  Branches     5354     5222     -132     
==========================================
- Hits        33947    33435     -512     
+ Misses       2711     2670      -41     
+ Partials      582      555      -27     
Impacted Files Coverage Δ
dvc/api/experiments.py 91.66% <ø> (+1.66%) ⬆️
dvc/commands/experiments/run.py 100.00% <ø> (+18.42%) ⬆️
dvc/commands/experiments/show.py 90.00% <ø> (ø)
dvc/commands/run.py 89.65% <ø> (ø)
dvc/commands/stage.py 75.63% <ø> (-0.21%) ⬇️
dvc/env.py 100.00% <ø> (ø)
dvc/repo/experiments/exceptions.py 72.34% <ø> (-2.66%) ⬇️
dvc/repo/experiments/executor/local.py 86.92% <ø> (-2.79%) ⬇️
dvc/repo/experiments/executor/ssh.py 29.81% <ø> (+0.18%) ⬆️
dvc/repo/experiments/queue/tempdir.py 68.13% <ø> (+1.81%) ⬆️
... and 31 more

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo force-pushed the 9221-droprevisit-usage-of-checkpoints branch from 16d73db to 4e03644 Compare March 29, 2023 11:56
@shcheklein
Copy link
Member

That was fast :) I don't think we discussed to drop this in the DVC itself yet. @dberenbaum wdyt? are we good with this? or we want to hide it first and think about the alternative?

@daavoo
Copy link
Contributor Author

daavoo commented Mar 30, 2023

That was fast :) I don't think we discussed to drop this in the DVC itself yet. @dberenbaum wdyt? are we good with this? or we want to hide it first and think about the alternative?

To clarify. It is not my intention to merge and drop it right away. I am planning to discuss with the team a branching strategy for the major release and that is where these draft P.Rs would go.

I just wanted to have the work done so:

  • It is easier to just rebase on the P.R.
  • When we discuss the major release, it doesn't bias the fact that "we still have to do this and that takes time", because it is done.

@dberenbaum dberenbaum added the 3.0 label May 9, 2023
@daavoo daavoo force-pushed the 9221-droprevisit-usage-of-checkpoints branch from 4e03644 to d6f8721 Compare May 16, 2023 09:23
@skshetry skshetry added this to the 3.0 milestone May 18, 2023
@daavoo daavoo force-pushed the 9221-droprevisit-usage-of-checkpoints branch 3 times, most recently from 7faf532 to ef1250b Compare May 22, 2023 12:24
@daavoo daavoo marked this pull request as ready for review May 22, 2023 12:50
@daavoo daavoo requested a review from skshetry May 22, 2023 12:50
@daavoo daavoo force-pushed the 9221-droprevisit-usage-of-checkpoints branch from ef1250b to 00f2c7d Compare May 22, 2023 13:30
@skshetry skshetry requested a review from pmrowla May 22, 2023 14:26
@skshetry skshetry merged commit 25313f5 into main May 23, 2023
@skshetry skshetry deleted the 9221-droprevisit-usage-of-checkpoints branch May 23, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
5 participants