targets from index #9259
Closed
targets from index #9259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Mar 28, 2023
Comment on lines
+492
to
+494
| index, targets = index_from_targets( | ||
| self, targets, with_deps=with_deps, recursive=recursive | ||
| ) |
There was a problem hiding this comment.
Opened for discussion. We short-circuit here to not load repo.index, and only load Index from targets.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9259 +/- ##
==========================================
- Coverage 92.88% 92.85% -0.04%
==========================================
Files 457 459 +2
Lines 36956 37164 +208
Branches 5341 5260 -81
==========================================
+ Hits 34325 34507 +182
- Misses 2105 2124 +19
- Partials 526 533 +7
... and 53 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@skshetry Sorry, I should've commented here. So what are your thoughts on this, is this still needed/viable? Or do you have alternatives? |
|
@skshetry Should we revive this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8768