stage.save: Set merge_versioned default to True.

[daavoo]

Closes #8828

[daavoo]

We are not testing cloud versioning on DVC side at all?

[codecov]

Codecov Report

Base: 93.64% // Head: 93.54% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (9d589a4) compared to base (61afdca).
Patch coverage: 50.00% of modified lines in pull request are covered.

❗ Current head 9d589a4 differs from pull request most recent head 9019208. Consider uploading reports for the commit 9019208 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8829      +/-   ##
==========================================
- Coverage   93.64%   93.54%   -0.11%     
==========================================
  Files         453      454       +1     
  Lines       36101    36145      +44     
  Branches     5237     5249      +12     
==========================================
+ Hits        33808    33811       +3     
- Misses       1787     1826      +39     
- Partials      506      508       +2     

Impacted Files	Coverage Δ
dvc/repo/worktree.py	10.25% <0.00%> (ø)
dvc/stage/__init__.py	93.85% <ø> (-0.22%)	⬇️
dvc/repo/add.py	100.00% <100.00%> (ø)
dvc/repo/index.py	81.32% <0.00%> (-8.49%)	⬇️
dvc/repo/experiments/queue/workspace.py	81.39% <0.00%> (-0.78%)	⬇️
dvc/repo/experiments/executor/base.py	83.57% <0.00%> (-0.59%)	⬇️
dvc/repo/experiments/__init__.py	87.76% <0.00%> (-0.36%)	⬇️
dvc/repo/data.py	98.83% <0.00%> (-0.27%)	⬇️
dvc/dependency/param.py	96.49% <0.00%> (-0.04%)	⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[daavoo]

If it's ok with having this always True we might as well just drop the option.
If it's not ok, we have to pass the flag in commit and move to make them work with cloud versioning stages

[pmrowla]

@daavoo It's safe but it makes save slower since it forces us to reload/reparse the existing .dvc/dvc.lock file each time. It'd be better to explicitly pass the flag in commit and move IMO

[daavoo]

@daavoo It's safe but it makes save slower since it forces us to reload/reparse the existing .dvc/dvc.lock file each time. It'd be better to explicitly pass the flag in commit and move IMO

It looks like those are all the places where stage.save is actually used so it would be the same as defaulting to True or not having the flag

[pmrowla]

We can probably just remove the flag then. This issue is more a side effect of our current add/commit/move behavior, where we always create a new stage from scratch, and then load the previous version if it exists later and try to merge the two, (as opposed to loading the stage if it exists first and then modifying it)