update: implement --to-remote flag #5343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
changed the title
efiop
reviewed
Feb 2, 2021
efiop
reviewed
Feb 2, 2021
Comment on lines
+7
to
+10
| url = stage.deps[0].path_info.url | ||
| stage.outs[0].hash_info = stage.repo.cloud.transfer( | ||
| url, jobs=jobs, remote=remote, command="update" | ||
| ) |
There was a problem hiding this comment.
Hm, seems like this is something we are doing over and over in add/import and now update. Makes me think this should really be some kind of flag/option for stage.save() and out.save() that would make it transfer stuff. We've had this discussion before and it wasn't clear back then, but maybe it is a good time. Or at least we could consider it and do it in the follow up.
There was a problem hiding this comment.
I also thought the same, and I think it would somehow make sense to have a function to do this in either stage or output.
isidentical
changed the title
efiop
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. (Awaiting Add docs regaring --to-remote option for add/import-url dvc.org#2091)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏