add: handle long filenames #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Jan 4, 2021
| @@ -174,7 +174,7 @@ def move(self, from_info, to_info, mode=None): | |||
| move(from_info, to_info, mode=mode) | |||
|
|
|||
| def copy(self, from_info, to_info): | |||
| tmp_info = to_info.parent / tmp_fname(to_info.name) | |||
| tmp_info = to_info.parent / tmp_fname("") | |||
There was a problem hiding this comment.
It seemed helpful before to keep the relation between the original file name and this temp file if something goes wrong, but in reality the data is already in cache at this point so it would be helpful to just provide intructions/mechanism to recover it. Aaand we delete this temp file anyway down below 🙂
|
@Mergifyio backport 1.11 |
efiop
force-pushed
the
fix-5200
branch
3 times, most recently
from
ef3c28d to
c891364
Compare
|
We are currently working on refactoring and separating cache save logic (e.g. in #4520 and refactoring ExternalRepo) that will allow us to separate saving and checking out and more gracefully recover from such errors. This PR is simply to handle happy path for the long filenames. |
mergify bot
pushed a commit
that referenced
this pull request
Jan 5, 2021
(cherry picked from commit b779a11)
efiop
added a commit
that referenced
this pull request
Jan 5, 2021
(cherry picked from commit b779a11) Co-authored-by: Ruslan Kuprieiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lack more tests for PATH_MAX and NAME_MAX across the board 🙁
Also need to catch initial internal checkout problems after add and provide some helpful message/mechanism to let the user know that the data is safe and can be recovered.
Fixes #5200
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏