docker: add example Dockerfile #2844

ghost · 2019-11-26T00:03:07Z

Build: docker build -t $TAG --build-arg USER_ID=${UID} .
Usage: docker run -ti --rm -v ${PWD}:/usr/src $TAG

Related #2774

jorgeorpinel · 2019-11-26T00:16:47Z

docker/Dockerfile

+
+# Set Zsh as the default shell
+SHELL ["/usr/bin/zsh", "-c"]
+


I think most people are used to Bash. It's not like we recommend Zsh over Bash in our docs. So this one may be unnecessary? Up to you guys.

@jorgeorpinel , using Zsh is not that different from Bash. I could argue that a lot of Bash users are using it because they are not aware of Zsh 😅

I'd prefer using zsh over bash, since the autocomplete features are better, thus, offering a better experience.

Agee about the autocomplete functions. I use Zsh myself 😬 I was just wondering whether a Bash user would find the running container unfamiliar or difficult to use because of differences between Bash and Zsh. But I guess that's not likely. So unless anyone else thinks otherwise, I'm OK with this.

docker/Dockerfile

casperdcl · 2019-11-26T01:17:21Z

docker/Dockerfile

+# Load and rice the completion menu with `zstyle`:
+# http://zsh.sourceforge.net/Doc/Release/Zsh-Modules.html#The-zsh_002fzutil-Module
+RUN echo "autoload -U compinit && compinit" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*:*:*:*:*' menu select" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*:matches' group 'yes'" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*:options' description 'yes'" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*:options' auto-description '%d'" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*:corrections' format ' %F{green}-- %d (errors: %e) --%f'" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*:descriptions' format ' %F{yellow}-- %d --%f'" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*:messages' format ' %F{purple} -- %d --%f'" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*:warnings' format ' %F{red}-- no matches found --%f'" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*:default' list-prompt '%S%M matches%s'" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*' format ' %F{yellow}-- %d --%f'" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*' group-name ''" >> $HOME/.zshrc \
+      && echo "zstyle ':completion:*' verbose yes" >> $HOME/.zshrc


really if all of this is genuinely useful for zsh users then surely it should be under the scripts/ directory just like completion/?

@casperdcl , it is usually provided by Zsh prompts like "pure" or frameworks like "oh-my-zsh".

so you don't need to deal with zstyle and stuff like that :)

In that case not really sure it belongs here. At the most maybe use pure or omz?

Basically I feel either put it in the scripts folder or remove it completely from the dockerfile.

Right, let's remove this, then; just for context, this is how it looks like

with zstyle:

without zstyle (no way to iterate between the options):

boring bash 😛

ghost · 2019-11-26T03:12:34Z

Ohh, by the way, this solves the uid problem)

efiop · 2019-11-26T11:09:11Z

docker/Dockerfile

+# Better movement with [Ctrl + →] and [Ctrl + ←]
+ENV INPUTRC=/etc/inputrc
+
+RUN set -ex \
+  && echo '"\e[1;5C": forward-word' >> /etc/inputrc \
+  && echo '"\e[1;5D": backward-word' >> /etc/inputrc
+


Don't quite understand what this is for and why this is needed in the docker file.

Usability. If you get into the shell, you won't be able to use Ctrl + arrows to move between words, for me it is annoying, that's why I added this.

again I think this is on the same level as zstyle - something that is generic shell/system-related and not about dvc

efiop · 2019-11-26T11:10:14Z

docker/Dockerfile

+# Set working directory.
+# Mount your project under the same path.
+WORKDIR /usr/src
+


Using /usr/src seems pretty strange. I think it is used in some systems (e.g. slackware?) to store actual sources.

It could be whatever you want, I've seen some Dockerfiles using /usr/src since it is expected that you'll only put one source into it.

efiop · 2019-11-26T11:10:30Z

docker/Dockerfile

+RUN apt-get update -y && apt-get install -y \
+      less \
+      git


What's up with this odd formatting?

Readability, you can see at first glance what packages are being installed.

efiop · 2019-11-26T11:11:51Z

docker/Dockerfile

+RUN wget \
+    -O /etc/bash_completion.d/dvc \
+    https://raw.githubusercontent.com/iterative/dvc/master/scripts/completion/dvc.bash


Not sure I understand why docker image needs bash completion. And if it does, why not zsh as well?

Usability. We opted to use Bash instead of Zsh. I don't see the point of using both.

efiop · 2019-11-26T11:13:14Z

docker/Dockerfile

+    https://raw.githubusercontent.com/iterative/dvc/master/scripts/completion/dvc.bash
+
+# Add a user to run DVC
+ARG USER_ID=1000


I suppose you are doing this so that files created by dvc are not owned by root, right? If so, now they are going to be owned by UID 1000, which is absolutely not guaranteed to match your current user on the host.

The user must build the image with their UID, see the description of the issue:
#2844 (comment)

efiop

I think I don't quite understand the purpose of this docker file. Is it to create a fully functional workspace for the user to loginto and use from inside?

ghost · 2019-11-26T16:35:46Z

I think I don't quite understand the purpose of this docker file. Is it to create a fully functional workspace for the user to loginto and use from inside?

@efiop, it is not clear. I'll close it for not having a clear reason to add it.

casperdcl · 2019-11-26T16:40:40Z

@efiop for me it's documentation for how to install dvc outside docker. As a secondary point it could be used to install dvc within docker for use in an automated workflow (no end user types commands - dvc and git are used to push/pull code and data instead of wget/curl)

ghost mentioned this pull request Nov 26, 2019

[WIP] install: add docker usage documentation iterative/dvc.org#811

Closed

docker: add example Dockerfile

94a0787

Related #2774

ghost requested review from casperdcl and shcheklein November 26, 2019 00:04

jorgeorpinel reviewed Nov 26, 2019

View reviewed changes

docker/Dockerfile Outdated Show resolved Hide resolved

docker: remove vim specific auto-setting comment

cd30547

casperdcl reviewed Nov 26, 2019

View reviewed changes

Mr. Outis added 3 commits November 25, 2019 21:20

docker: use bash instead of zsh

0939985

docker: remove LANG, already set by base image

c1dab89

docker: better phrasing

898e0ac

efiop requested review from casperdcl and jorgeorpinel November 26, 2019 06:54

efiop reviewed Nov 26, 2019

View reviewed changes

ghost closed this Nov 26, 2019

weekly-digest bot mentioned this pull request Dec 1, 2019

Weekly Digest (24 November, 2019 - 1 December, 2019) #2876

Closed

iesahin mentioned this pull request Mar 15, 2021

mnist tutorial failing iterative/katacoda-scenarios#15

Open

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docker: add example Dockerfile #2844

docker: add example Dockerfile #2844

ghost commented Nov 26, 2019 •

edited by casperdcl

Loading

jorgeorpinel Nov 26, 2019

ghost Nov 26, 2019

jorgeorpinel Nov 26, 2019

casperdcl Nov 26, 2019

ghost Nov 26, 2019

casperdcl Nov 26, 2019

ghost Nov 26, 2019

ghost Nov 26, 2019

ghost commented Nov 26, 2019 •

edited by ghost

Loading

efiop Nov 26, 2019

ghost Nov 26, 2019

casperdcl Nov 26, 2019

efiop Nov 26, 2019

ghost Nov 26, 2019

efiop Nov 26, 2019

ghost Nov 26, 2019

efiop Nov 26, 2019

ghost Nov 26, 2019

efiop Nov 26, 2019

ghost Nov 26, 2019

efiop left a comment

ghost commented Nov 26, 2019

casperdcl commented Nov 26, 2019

docker: add example Dockerfile #2844

docker: add example Dockerfile #2844

Conversation

ghost commented Nov 26, 2019 • edited by casperdcl Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Nov 26, 2019 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

efiop left a comment

Choose a reason for hiding this comment

ghost commented Nov 26, 2019

casperdcl commented Nov 26, 2019

ghost commented Nov 26, 2019 •

edited by casperdcl

Loading

ghost commented Nov 26, 2019 •

edited by ghost

Loading