Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchmarks): force older pygit2 for older DVC versions #10447

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

shcheklein
Copy link
Member

Fixes (hopefully) failing benchmarks.

If you run it locally with:

DVC_TEST=true python -m pytest --benchmark-group-by func --dvc-revs 3.10.0 --pyargs dvc.testing.benchmarks.cli.commands.test_plots::test_plots --dataset mnist

and then:

(.venv) √ pytest-14/dvc-project0 % /private/var/folders/8f/fbysfztx1mb953_gpwl477p80000gn/T/pytest-of-ivan/pytest-14/dvc-venv-3.10.00/bin/dvc plots diff HEAD
ERROR: unexpected error - cannot import name 'GIT_OBJ_COMMIT' from 'pygit2' (/private/var/folders/8f/fbysfztx1mb953_gpwl477p80000gn/T/pytest-of-ivan/pytest-14/dvc-venv-3.10.00/lib/python3.12/site-packages/pygit2/__init__.py)

It's all related to:

iterative/scmrepo#359

@shcheklein shcheklein added testing Related to the tests and the testing infrastructure maintenance labels Jun 2, 2024
@shcheklein shcheklein self-assigned this Jun 2, 2024
@shcheklein shcheklein requested review from skshetry and dberenbaum June 2, 2024 18:12
@skshetry skshetry merged commit b69b368 into main Jun 3, 2024
19 checks passed
@skshetry skshetry deleted the fix/benchmarks-pygit2-removed-constants branch June 3, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance testing Related to the tests and the testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants