dvc: s3: allow configuring anonymous access #10407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10407 +/- ##
==========================================
+ Coverage 90.34% 90.49% +0.14%
==========================================
Files 480 502 +22
Lines 35893 38982 +3089
Branches 4135 5309 +1174
==========================================
+ Hits 32426 35275 +2849
- Misses 2870 3012 +142
- Partials 597 695 +98 ☔ View full report in Codecov by Sentry. |
dberenbaum
reviewed
Apr 25, 2024
dvc/config_schema.py
Outdated
| @@ -193,6 +193,7 @@ def __call__(self, data): | |||
| "session_token": str, | |||
| Optional("listobjects", default=False): Bool, # obsoleted | |||
| Optional("use_ssl", default=True): Bool, | |||
| Optional("anon", default=False): Bool, | |||
There was a problem hiding this comment.
Agree with @shcheklein that we should use allow_anonymous_login here.
skshetry
approved these changes
Apr 26, 2024
|
Can we also change |
dberenbaum
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
see: