Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get: update show-url to take remote args #10349

Merged
merged 2 commits into from
Mar 11, 2024
Merged

get: update show-url to take remote args #10349

merged 2 commits into from
Mar 11, 2024

Conversation

dberenbaum
Copy link
Collaborator

See https://discuss.dvc.org/t/how-can-i-dvc-get-using-a-non-default-remote-storage/1992.

This PR:

  • Updates dvc get --show-url so that it respects --remote and --remote-config
  • Updates dvc.api.get_url to take remote, config, and remote_config kwargs like dvc.api.open

@dberenbaum dberenbaum requested a review from skshetry March 11, 2024 13:22
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (6bdf41a) to head (58faf0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10349      +/-   ##
==========================================
+ Coverage   90.66%   90.67%   +0.01%     
==========================================
  Files         500      500              
  Lines       38670    38679       +9     
  Branches     5591     5591              
==========================================
+ Hits        35059    35073      +14     
+ Misses       2967     2963       -4     
+ Partials      644      643       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dberenbaum dberenbaum enabled auto-merge (rebase) March 11, 2024 13:36
@dberenbaum dberenbaum merged commit 603da1c into main Mar 11, 2024
20 checks passed
@dberenbaum dberenbaum deleted the get-show-url-remote branch March 11, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants