Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle auto push errors #10340

Merged
merged 1 commit into from
Mar 5, 2024
Merged

handle auto push errors #10340

merged 1 commit into from
Mar 5, 2024

Conversation

dberenbaum
Copy link
Collaborator

@dberenbaum dberenbaum commented Mar 5, 2024

Fixes Handle case where remote doesn't exist in #10137.

This raises a warning and disables auto push if remote validation fails. Without this PR, it fails early, which is also reasonable, but I think it's less desirable for this scenario. If I set up a new repo and login to Studio, I won't be able to run any experiments until I have a dvc and git remote configured or I disable auto push.

@dberenbaum dberenbaum requested a review from skshetry March 5, 2024 14:23
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.64%. Comparing base (0001cc3) to head (5dfa676).

Files Patch % Lines
dvc/repo/experiments/executor/base.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10340   +/-   ##
=======================================
  Coverage   90.63%   90.64%           
=======================================
  Files         500      500           
  Lines       38626    38641   +15     
  Branches     5584     5586    +2     
=======================================
+ Hits        35010    35027   +17     
+ Misses       2971     2969    -2     
  Partials      645      645           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dberenbaum dberenbaum enabled auto-merge (rebase) March 5, 2024 14:43
@dberenbaum dberenbaum merged commit cf9855a into main Mar 5, 2024
20 checks passed
@dberenbaum dberenbaum deleted the auto-push-errors branch March 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants