Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data status --not-in-remote: not working #9541

Closed
Tracked by #7093
dberenbaum opened this issue Jun 5, 2023 · 2 comments · Fixed by #9587
Closed
Tracked by #7093

data status --not-in-remote: not working #9541

dberenbaum opened this issue Jun 5, 2023 · 2 comments · Fixed by #9587
Assignees
Labels
p0-critical Critical issue. Needs to be fixed ASAP. regression Ohh, we broke something :-( release-blocker Blocks a release

Comments

@dberenbaum
Copy link
Collaborator

Bug Report

Description

dvc data status --not-in-remote doesn't report what is not in remote. This looks like a regression introduced here (cc @efiop).

Reproduce

git init -q repo
cd repo
dvc init -q
dvc remote add -q -d storage /tmp/remote
touch test
dvc add -q test
git add .
git commit -q -m "init"
dvc data status --not-in-remote

This outputs no changes.

Expected

An output that shows data is missing from the remote.

Environment information

Output of dvc doctor:

$ dvc doctor
DVC version: 3.0.0a2.dev11+g78637713c
-------------------------------------
Platform: Python 3.10.10 on macOS-13.3.1-arm64-arm-64bit
Subprojects:
        dvc_data = 0.54.3
        dvc_objects = 0.22.0
        dvc_render = 0.5.3
        dvc_task = 0.2.1
        scmrepo = 1.0.3
Supports:
        azure (adlfs = 2023.4.0, knack = 0.10.1, azure-identity = 1.12.0),
        gdrive (pydrive2 = 1.15.3),
        gs (gcsfs = 2022.11.0),
        hdfs (fsspec = 2022.11.0, pyarrow = 11.0.0),
        http (aiohttp = 3.7.4.post0, aiohttp-retry = 2.8.3),
        https (aiohttp = 3.7.4.post0, aiohttp-retry = 2.8.3),
        oss (ossfs = 2021.8.0),
        s3 (s3fs = 2022.11.0, boto3 = 1.24.59),
        ssh (sshfs = 2023.4.1),
        webdav (webdav4 = 0.9.8),
        webdavs (webdav4 = 0.9.8),
        webhdfs (fsspec = 2022.11.0)
Config:
        Global: /Users/dave/Library/Application Support/dvc
        System: /Library/Application Support/dvc
@dberenbaum dberenbaum added regression Ohh, we broke something :-( release-blocker Blocks a release labels Jun 5, 2023
@dberenbaum dberenbaum added this to DVC Jun 5, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Jun 5, 2023
@dberenbaum dberenbaum moved this from Backlog to Todo in DVC Jun 5, 2023
@dberenbaum
Copy link
Collaborator Author

Besides being a regression, this is a blocker for #5369

@efiop
Copy link
Contributor

efiop commented Jun 12, 2023

One of the changes in dvc-data caused this. Preparing a fix.

efiop added a commit to efiop/dvc-data that referenced this issue Jun 12, 2023
efiop added a commit to efiop/dvc-data that referenced this issue Jun 12, 2023
efiop added a commit to efiop/dvc-data that referenced this issue Jun 12, 2023
efiop added a commit to efiop/dvc that referenced this issue Jun 12, 2023
efiop added a commit to iterative/dvc-data that referenced this issue Jun 12, 2023
@efiop efiop moved this from Todo to Review In Progress in DVC Jun 12, 2023
efiop added a commit that referenced this issue Jun 12, 2023
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in DVC Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0-critical Critical issue. Needs to be fixed ASAP. regression Ohh, we broke something :-( release-blocker Blocks a release
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants