-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdrive: Shared drives support #914
gdrive: Shared drives support #914
Conversation
@@ -226,6 +226,24 @@ On successful access token generation, token data will be cached in git ignored | |||
directory with path `.dvc/tmp/gdrive-user-credentials.json`. Do not share token | |||
data with anyone else to prevent unauthorized access to your Google Drive. | |||
|
|||
#### Shared drives support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about adding subheaders in hidden sections. We don't even have H4s anywyere yet, this would be the first one in all the docs actually (except for 2 wrong ones I just noticed in dvc version
which I'll fix soon). The anchor icon is not displayed properly:
and if you try to use the direct link (https://dvc.org/doc/command-reference/remote/add#shared-drives-support) the page won't open the section and scroll to that header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I just found another one in this same doc actually, inside the Aliyun OSS section.
Anyway, since this is merged I'll just come up with a better solution in a near-future "regular updates" PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgeorpinel yep, we can change it to a regular bold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK addressed. Feel free to review: 26d9928 Thanks
and other improvements near the changed text per #914 (review)
Related to iterative/dvc#3016