Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp: Drop init. #4415

Merged
merged 2 commits into from
Mar 22, 2023
Merged

exp: Drop init. #4415

merged 2 commits into from
Mar 22, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Mar 20, 2023

Closes #4336

@daavoo daavoo requested a review from a team as a code owner March 20, 2023 12:37
@shcheklein shcheklein temporarily deployed to dvc-org-drop-checkpoint-kow1in March 20, 2023 12:39 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023 •
edited
Loading

Link Check Report

There were no links to check!

@daavoo daavoo requested review from a team and removed request for a team March 20, 2023 13:07
@daavoo daavoo self-assigned this Mar 20, 2023
@daavoo daavoo force-pushed the drop-checkpoints branch from 4f9fce8 to 4be05a8 Compare March 20, 2023 16:28
@shcheklein shcheklein temporarily deployed to dvc-org-drop-checkpoint-kow1in March 20, 2023 16:28 Inactive
@shcheklein
Copy link
Member

@daavoo can we please do on thing at a time? :)

Are we in agreement that we don't support checkpoint anymore? (I'm personally still not convinced. Primarily because I'm not sure we have a decent replacement for this. I think it's needed if we were to remove this).

@daavoo daavoo force-pushed the drop-checkpoints branch from 4be05a8 to 85e5b4e Compare March 21, 2023 09:29
@shcheklein shcheklein temporarily deployed to dvc-org-drop-checkpoint-kow1in March 21, 2023 09:29 Inactive
@daavoo daavoo changed the title exp: Drop checkpoints and init. exp: Drop init. Mar 21, 2023
@daavoo
Copy link
Contributor Author

daavoo commented Mar 21, 2023

@daavoo can we please do on thing at a time? :)

Updated to only remove exp init.

Are we in agreement that we don't support checkpoint anymore? (I'm personally still not convinced. Primarily because I'm not sure we have a decent replacement for this. I think it's needed if we were to remove this).

I will create an issue and comment in https://github.com/iterative/vscode-dvc-demo (afaik the only active demo using checkpoints)

@daavoo daavoo mentioned this pull request Mar 21, 2023
Closed
@daavoo
Copy link
Contributor Author

daavoo commented Mar 21, 2023

Are we in agreement that we don't support checkpoint anymore? (I'm personally still not convinced. Primarily because I'm not sure we have a decent replacement for this. I think it's needed if we were to remove this).

I will create an issue and comment in https://github.com/iterative/vscode-dvc-demo (afaik the only active demo using checkpoints)

iterative/dvc#9221

@dberenbaum
Copy link
Contributor

@daavoo Since you dropped checkpoints from this, I think there's a reference we need to drop in https://dvc.org/doc/user-guide/experiment-management/checkpoints.

Also, should we stop showing dvc exp init in the CLI as well?

@shcheklein shcheklein temporarily deployed to dvc-org-drop-checkpoint-kow1in March 22, 2023 13:36 Inactive
@dberenbaum
Copy link
Contributor

@daavoo Since you dropped checkpoints from this, I think there's a reference we need to drop in https://dvc.org/doc/user-guide/experiment-management/checkpoints.

Pushed an update to address this.

@dberenbaum dberenbaum merged commit 88f3f27 into main Mar 22, 2023
@dberenbaum dberenbaum deleted the drop-checkpoints branch March 22, 2023 13:48
@daavoo daavoo mentioned this pull request Mar 29, 2023
Merged
@dberenbaum dberenbaum mentioned this pull request Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omesser omesser omesser approved these changes

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees

@daavoo daavoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop dvc exp init
4 participants
@daavoo @shcheklein @dberenbaum @omesser