Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

June Heartbeat for review #2567

Merged
merged 11 commits into from
Jun 18, 2021
Merged

June Heartbeat for review #2567

merged 11 commits into from
Jun 18, 2021

Conversation

jendefig
Copy link
Contributor

@jorgeorpinel Ivan's out this week. Can you do the fine tooth comb review for this?

@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 15, 2021 23:40 Inactive
@jendefig jendefig requested a review from jorgeorpinel June 15, 2021 23:40
@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 15, 2021 23:58 Inactive
@jendefig

This comment has been minimized.

Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted two possible typos

content/blog/2021-06-15-june-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
content/blog/2021-06-15-june-21-dvc-heartbeat.md Outdated Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 16, 2021 15:14 Inactive
@shcheklein shcheklein had a problem deploying to dvc-org-june-heartbeat-ehmcbns June 16, 2021 15:18 Failure
@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 16, 2021 15:25 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 16, 2021 21:13 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 16, 2021 21:51 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 17, 2021 11:46 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 17, 2021 11:56 Inactive
@jendefig
Copy link
Contributor Author

@jorgeorpinel This is ready to go I think! I covered everything. Can we merge?

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion ☝️ Up to you!

@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 17, 2021 21:38 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-june-heartbeat-ehmcbns June 18, 2021 18:26 Inactive
@jendefig
Copy link
Contributor Author

@jorgeorpinel Just adjusted the dates for today. Can you merge this?

@jorgeorpinel
Copy link
Contributor

Sure. I thought you were able to merge once approved.

@jorgeorpinel jorgeorpinel merged commit 63b0e89 into master Jun 18, 2021
@jendefig
Copy link
Contributor Author

Thanks so much @jorgeorpinel ! 🙏

@jendefig jendefig deleted the june-heartbeat branch June 18, 2021 20:50
Comment on lines +83 to +84
link="https://medium.com"
image="/uploads/images/2021-06-15/neda-sultova.png"/>
Copy link
Contributor

@jorgeorpinel jorgeorpinel Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all these 6-15 image paths are broken (should be 6-18) as you noticed, @jendefig

image

This comment was marked as off-topic.

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants