-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: add to-cache docs #2246
cmd: add to-cache docs #2246
Conversation
tutorial. When it is ready to go, we can add `data.xml` to our cache directly; | ||
|
||
``` | ||
$ dvc add https://data.dvc.org/get-started/data.xml -o data.xml | ||
``` |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not sure about the https://data.dvc.org/get-started/data.xml example... We could keep it hypothetical with some abstract path like /mnt/nfs/raw/data.xml
(or some better idea) or ssh://[email protected]/raw/data.xml
Idk, I guess it's not very important but data.dvc.org is kind of an internal company thing (not a secret but still).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a review with specific suggestions.
- Let's also address ref: add --out for local targets #2220 here?
I can take this over if needed after your next iteration @isidentical, thanks.
How should we document it though? Separate example (Tutorial: copying datasets in the same workspace) or just a note under the |
Checking on the status of this @isidentical @jorgeorpinel ? |
That should be enough for now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy edits on the example:
Restyle cmd: add to-cache docs
Thanks @jorgeorpinel! |
Np! BTW we forgot to update the link in the note in https://dvc.org/doc/user-guide/managing-external-data (currently goes to iterative/dvc#4520). I'll do it separately. |
* guide: update Ext Data guide link to add to-cache/remote examples per #2246 (comment) * ref: config options copy edits * ref: destroy copy edit
Part of #2121
Closes #2220