Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in 2.0 #2228

Closed
Tracked by #5367
dberenbaum opened this issue Feb 22, 2021 · 14 comments
Closed
Tracked by #5367

Breaking changes in 2.0 #2228

dberenbaum opened this issue Feb 22, 2021 · 14 comments
Assignees
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints

Comments

@dberenbaum
Copy link
Contributor

dberenbaum commented Feb 22, 2021

Need a list of all breaking changes in 2.0 to post with release

UPDATE: Jump to #2228 (comment) for summary.

@dberenbaum dberenbaum self-assigned this Feb 22, 2021
@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints labels Feb 22, 2021
@dberenbaum
Copy link
Contributor Author

@jorgeorpinel
Copy link
Contributor

Will this be blogged?

@dberenbaum
Copy link
Contributor Author

Probably so. Thoughts @dmpetrov ?

@dberenbaum
Copy link
Contributor Author

Summary/questions on breaking changes:

iterative/dvc#5187 @efiop
What is the breaking change? Did behavior change for stages without deps or outs?

iterative/dvc#5128 @skshetry

Is this the only breaking change?

The only thing that makes v1 -> v2 incompatible is the parametrization syntax (foreach .. do and vars can be made compatible). As an example, if user were using ${TMPDIR} in the cmd, v2 will start complaining considering it as a parametrization syntax rather than an env var and they'd have to escape them with \ (as, ${TMPDIR}).

Let me know your feedback on this proposed summary: "Environment variables inside the cmd of a stage using ${VAR} syntax must be escaped as \${VAR} in 2.0 due to the use of ${} syntax for templating."

iterative/dvc#5063 @skshetry
When was set supported? What was the syntax for it? Was this an "experimental" feature? I'm wondering if this actually needs to be documented as a breaking change for the release.

iterative/dvc#4910 @pmrowla
Similar to the one above, since experiments have been only implemented so far as an experimental feature, do we need to document changes to them as "breaking" for the release?

@pmrowla
Copy link
Contributor

pmrowla commented Feb 25, 2021

I don't think the experiments change needs to be documented as breaking, that PR and the notes on the wiki page were flagged as breaking for any users that had been testing the experimental feature already

@isidentical
Copy link
Contributor

isidentical commented Mar 2, 2021

iterative/dvc#5527 dropped support for external outputs in google storage, and also changed the default checksum from md5 to etag.

iterative/dvc#5485 dropped support for login with p12 files on service authentication for gdrive.

@dberenbaum
Copy link
Contributor Author

iterative/dvc#5187 @efiop
What is the breaking change? Did behavior change for stages without deps or outs?

Stages without dependencies will not always run as if changed. Instead, use --always-changed.

Thoughts on the wording @efiop?

iterative/dvc#5063 @skshetry
When was set supported? What was the syntax for it? Was this an "experimental" feature? I'm wondering if this actually needs to be documented as a breaking change for the release.

Experimental feature - doesn't need to be documented.

@dberenbaum
Copy link
Contributor Author

Updated breaking changes summary:

  • Dropped support for external outputs in Google Cloud Storage and changed the default checksum from md5 to etag.
  • Dropped support for login with p12 files on service authentication for Google Drive.
  • Stages without dependencies will not always run as if changed. Instead, use --always-changed.
  • Environment variables inside the cmd of a stage using ${VAR} syntax must be escaped as \${VAR} in 2.0 due to the use of ${} syntax for templating.

@jorgeorpinel
Copy link
Contributor

Note that for now at least these are listed in https://github.com/iterative/dvc/releases/tag/2.0.0 so users can potentially find the info from dvc.org/doc (clicking on changelog and scrolling).

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Mar 9, 2021

Oh. It's also published on https://dvc.org/blog/dvc-2-0-release so is this issue addressed @dberenbaum ?

@dberenbaum
Copy link
Contributor Author

Yup, thanks for pinging me on this one!

@VOvchinnikov
Copy link

Are there any plans to restore the support for external outputs for Google Cloud Storage any time soon? Or at all, for that matter?
That would've been greatly appreciated 😃

@daavoo
Copy link
Contributor

daavoo commented Dec 14, 2022

Are there any plans to restore the support for external outputs for Google Cloud Storage any time soon? Or at all, for that matter?

Hi @VOvchinnikov , do you mind opening a feature request in https://github.com/iterative/dvc-gs

@VOvchinnikov
Copy link

@daavoo not at all, will do just that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints
Projects
None yet
Development

No branches or pull requests

7 participants