fix: replace deprecated gitlab ci var #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLab 16.x deprecated several variables including CI_BUILD_REF_NAME. In order to be exhaustive, two variables are replacing it: CI_COMMIT_BRANCH (prefered) and CI_COMMIT_REF_NAME. Issue: iterative#1403
dacbd
reviewed
Jul 20, 2023
Test Comment |
Test Comment |
Test Comment |
Test Comment |
|
@dacbd I fixed the credentials build missing argument. |
|
@nipierre Thanks, I'm addressing a container issue that is blocking some of our automation, my plan is to try and have this merged and released by the end of the week for you. Thanks again for this patch! |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
Test Comment |
dacbd
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLab 16.x deprecated several variables including CI_BUILD_REF_NAME. In order to be exhaustive, two variables are replacing it: CI_COMMIT_BRANCH (prefered) and CI_COMMIT_REF_NAME.
Issue: #1403
I put the two variables in order to cover most of the cases one can think of in terms of pipeline trigger.
@dacbd