test: enhance test-timers

In test-timers, confirm that all input values that should be coerced to 1 ms are not being coerced to a significantly larger value. This eliminates the need for the separate test-regress-nodejsGH-897. PR-URL: nodejs#10960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
italoacasas · Jan 30, 2017 · e6a7d59 · e6a7d59
1 parent 7e847af
commit e6a7d59
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 27 deletions.
diff --git a/test/parallel/test-regress-GH-897.js b/test/parallel/test-regress-GH-897.js
diff --git a/test/parallel/test-timers.js b/test/parallel/test-timers.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 
 const inputs = [
@@ -18,13 +18,14 @@ const inputs = [
   -10,
   -1,
   -0.5,
+  -0.1,
   -0.0,
   0,
   0.0,
+  0.1,
   0.5,
   1,
   1.0,
-  10,
   2147483648,     // browser behaviour: timeouts > 2^31-1 run on next tick
   12345678901234  // ditto
 ];
@@ -43,10 +44,17 @@ inputs.forEach(function(value, index) {
   }, value);
 });
 
-process.on('exit', function() {
-  // assert that all timers have run
+// All values in inputs array coerce to 1 ms. Therefore, they should all run
+// before a timer set here for 2 ms.
+
+setTimeout(common.mustCall(function() {
+  // assert that all other timers have run
   inputs.forEach(function(value, index) {
-    assert.strictEqual(true, timeouts[index]);
-    assert.strictEqual(true, intervals[index]);
+    assert(timeouts[index]);
+    assert(intervals[index]);
   });
-});
+}), 2);
+
+// Test 10 ms timeout separately.
+setTimeout(common.mustCall(function() {}), 10);
+setInterval(common.mustCall(function() { clearInterval(this); }), 10);