Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

add in kustomization in root directory to allow for ease of use with … #780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kampe
Copy link

@Kampe Kampe commented Sep 2, 2020

…kustomize remote base

This allows people to utilize this repository as a base and patch overlays on top.

ie

Bases:
- github.com/istio/operator

@Kampe Kampe requested a review from a team as a code owner September 2, 2020 19:42
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Sep 2, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2020
@ostromart
Copy link
Contributor

This repo is inactive and out of date - see istio/istio/manifests instead.

@Kampe
Copy link
Author

Kampe commented Sep 2, 2020

Interesting, thats sad because I don't think this is useful all in one place - kustomize remote base assumes the root dir, of which in the istio proper repository, I don't believe they're even present there anymore and unfortunately this would live in the root of the repo and there's no logic there around the operator aside from mention in the .MD

@howardjohn
Copy link
Member

howardjohn commented Sep 10, 2020 via email

@Kampe
Copy link
Author

Kampe commented Sep 10, 2020

You can reference resources by the raw files in a kustomization.yaml - however I'm pretty sure the remote base kustomization requires a kustomization to live in the root, and point to either resources itself, or another kustomization.yaml in a different directory in which points to the resources.

Edit: seems your are right and you can specify a URI (invalid to github) and it'll traverse the tree to the kustomize assets, do wonder if this is a feature or a bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants