Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Return error to reconciler when process manifest fails #664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return error to reconciler when process manifest fails #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/helmreconciler/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package helmreconciler

import (
"fmt"
"sync"

"k8s.io/apimachinery/pkg/runtime"
Expand Down Expand Up @@ -115,7 +116,11 @@ func (h *HelmReconciler) Reconcile() error {
errs = util.AppendErr(errs, h.customizer.Listener().EndPrune())

errs = util.AppendErr(errs, h.customizer.Listener().EndReconcile(h.instance, status))

for _, v := range status.Status {
if v.Error != "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to check against the enum status field (!=ERROR).

errs = util.AppendErr(errs, fmt.Errorf(v.Error+"\n"))
}
}
return errs.ToError()
}

Expand Down