Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacote test failure with 4.4.2 #183

Closed
zkat opened this issue May 20, 2018 · 0 comments
Closed

pacote test failure with 4.4.2 #183

zkat opened this issue May 20, 2018 · 0 comments

Comments

@zkat
Copy link
Contributor

zkat commented May 20, 2018

b0c5843 seems to have broken pacote on Windows. I'm not really sure how, or why, but you can see the failure here: https://ci.appveyor.com/project/zkat/pacote/build/1.0.876/job/462gfat2t5gpb0ry#L144, which has to do with pacote's onentry shenanigans.

I installed 4.4.1 and the problem went away, so I assume it's that specific commit causing it.
@zkat zkat added the bug label May 20, 2018
zkat added a commit to npm/npm that referenced this issue May 20, 2018
@zkat
[email protected]
bb5b8c7 
Reverting tar version due to isaacs/node-tar#183
zkat added a commit to zkat/pacote that referenced this issue May 22, 2018
@zkat
deps: lock tar to 4.4.1 for now
770a7c4 
Until isaacs/node-tar#183 is fixed
@isaacs isaacs closed this as completed in 4b7738d May 23, 2018
iarna pushed a commit to npm/npm that referenced this issue May 24, 2018
@zkat @iarna
[email protected]
b0bf908 
Reverting tar version due to isaacs/node-tar#183
iarna pushed a commit to npm/npm that referenced this issue May 24, 2018
@zkat @iarna
[email protected]
1d07134 
Reverting tar version due to isaacs/node-tar#183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zkat