Use PartialReflect

Looks like it should be `PartialReflect` after all: bevyengine/bevy#7207
ironpeak · Nov 6, 2024 · 9d175e4 · 9d175e4
1 parent 64b98c6
commit 9d175e4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/core/event_registry/client_event.rs b/src/core/event_registry/client_event.rs
@@ -96,7 +96,7 @@ pub trait ClientEventAppExt {
         event: &ReflectEvent,
         cursor: &mut Cursor<Vec<u8>>,
     ) -> bincode::Result<()> {
-        let serializer = ReflectSerializer::new(&*event.0.as_partial_reflect(), ctx.registry);
+        let serializer = ReflectSerializer::new(&*event.0, ctx.registry);
         DefaultOptions::new().serialize_into(cursor, &serializer)
     }
 
@@ -106,11 +106,11 @@ pub trait ClientEventAppExt {
     ) -> bincode::Result<ReflectEvent> {
         let mut deserializer = bincode::Deserializer::with_reader(cursor, DefaultOptions::new());
         let reflect = ReflectDeserializer::new(ctx.registry).deserialize(&mut deserializer)?;
-        Ok(ReflectEvent(reflect.try_into_reflect().unwrap()))
+        Ok(ReflectEvent(reflect))
     }
 
     #[derive(Event)]
-    struct ReflectEvent(Box<dyn Reflect>);
+    struct ReflectEvent(Box<dyn PartialReflect>);
     ```
     */
     fn add_client_event_with<E: Event>(

diff --git a/src/core/event_registry/server_event.rs b/src/core/event_registry/server_event.rs
@@ -103,7 +103,7 @@ pub trait ServerEventAppExt {
         event: &ReflectEvent,
         cursor: &mut Cursor<Vec<u8>>,
     ) -> bincode::Result<()> {
-        let serializer = ReflectSerializer::new(&*event.0.as_partial_reflect(), ctx.registry);
+        let serializer = ReflectSerializer::new(&*event.0, ctx.registry);
         DefaultOptions::new().serialize_into(cursor, &serializer)
     }
 
@@ -113,11 +113,11 @@ pub trait ServerEventAppExt {
     ) -> bincode::Result<ReflectEvent> {
         let mut deserializer = bincode::Deserializer::with_reader(cursor, DefaultOptions::new());
         let reflect = ReflectDeserializer ::new(ctx.registry).deserialize(&mut deserializer)?;
-        Ok(ReflectEvent(reflect.try_into_reflect().unwrap()))
+        Ok(ReflectEvent(reflect))
     }
 
     #[derive(Event)]
-    struct ReflectEvent(Box<dyn Reflect>);
+    struct ReflectEvent(Box<dyn PartialReflect>);
     ```
     */
     fn add_server_event_with<E: Event>(