Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect OffScreenMargin for elements in chrome layer. #439

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Respect OffScreenMargin for elements in chrome layer. #439

merged 1 commit into from
Oct 19, 2024

Conversation

rabbitism
Copy link
Member

@rabbitism rabbitism commented Oct 18, 2024 •
edited
Loading

Close #438

@rabbitism
Copy link
Member Author

@wslsj888 @JusterZhu please hep to review

@rabbitism rabbitism requested a review from JusterZhu October 18, 2024 11:35
@wslsj888
Copy link

well done!

@JusterZhu
Copy link
Collaborator

When using the OffScreenMargin property to resolve the current issue, has it been tested on different resolutions?

@rabbitism
Copy link
Member Author

When using the OffScreenMargin property to resolve the current issue, has it been tested on different resolutions?

This is a fixed value, and only has a valid value on os-windows.

JusterZhu
JusterZhu approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@JusterZhu JusterZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later, we may need to label the operating system platform where the issue occurs on the label.

@rabbitism rabbitism merged commit c23893b into main Oct 19, 2024
@rabbitism rabbitism added this to the October release milestone Oct 21, 2024
@rabbitism rabbitism deleted the 438-title branch November 4, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JusterZhu JusterZhu JusterZhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
October release
Development

Successfully merging this pull request may close these issues.

UrsaWindow最大化问题
3 participants
@rabbitism @wslsj888 @JusterZhu