Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all possible exceptions when trying to import the debugger #987

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

JohanMabille
Copy link
Contributor

Fixes #986

The DebuggerInitializationError is not part of the public API of debugpy, thus the "catch all exceptions" change.

@JohanMabille
Copy link
Contributor Author

Ok we need to handle this in a better way. Will do after lunch.

@JohanMabille JohanMabille marked this pull request as draft September 9, 2022 13:27
@JohanMabille JohanMabille marked this pull request as ready for review September 9, 2022 13:55
@blink1073
Copy link
Contributor

Is this ready for review @JohanMabille?

@blink1073 blink1073 changed the title Handle all possible excpetions when trying to import thr debugger Handle all possible exceptions when trying to import the debugger Sep 13, 2022
@JohanMabille
Copy link
Contributor Author

Yes

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 861b124 into ipython:main Sep 13, 2022
@JohanMabille JohanMabille deleted the debug_error branch September 13, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DebuggerInitializationError kills the kernel
2 participants