Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update @multiformats/multiaddr #213

Merged
merged 3 commits into from
Nov 29, 2023
Merged

deps: update @multiformats/multiaddr #213

merged 3 commits into from
Nov 29, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Nov 28, 2023

  • chore: ignore .DS_Store files
  • fix: tests and update multiformats/multiaddr

This work is part of ipfs/ipfs-webui#2176


Also, if you look at the Actions of this repo, many tests have been failing in the CI for a while. This PR addresses that, as well as updates @multiformats/multiaddr

image

@SgtPooki
Copy link
Member Author

restarting failed workflow: https://github.com/ipfs/js-kubo-rpc-client/actions/runs/7024231846/job/19112529226?pr=213#step:5:740

Error [HTTPError]: failed to check pin status for requestid="req-3" due to error: reason: "NotFound", details: "Error\n    at notFound (/home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/mock-ipfs-pinning-service/service/util.js:25:52)\n    at getPin (/home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/mock-ipfs-pinning-service/service/pins.js:141:18)\n    at /home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/mock-ipfs-pinning-service/service/util.js:69:43\n    at OASRouter (/home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/oas-tools/common/middleware/oas-router.js:322:22)\n    at Layer.handle [as handle_request] (/home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/express/lib/router/layer.js:95:5)\n    at next (/home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/express/lib/router/route.js:144:13)\n    at Route.dispatch (/home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/express/lib/router/route.js:114:3)\n    at Layer.handle [as handle_request] (/home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/express/lib/router/layer.js:95:5)\n    at /home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/express/lib/router/index.js:284:15\n    at param (/home/runner/work/js-kubo-rpc-client/js-kubo-rpc-client/node_modules/express/lib/router/index.js:365:14)": 404 Not Found

@SgtPooki
Copy link
Member Author

im able to repro the error with aegir test -t browser -g '.pin.remote.add' -- --browser firefox

@SgtPooki SgtPooki marked this pull request as ready for review November 29, 2023 00:16
@hacdias hacdias merged commit 8b2ee7f into master Nov 29, 2023
18 checks passed
@hacdias hacdias deleted the deps/update-multiaddr branch November 29, 2023 08:35
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
## [3.0.2](v3.0.1...v3.0.2) (2023-11-29)

### Bug Fixes

* tests and update multiformats/multiaddr ([#213](#213)) ([8b2ee7f](8b2ee7f))

### Trivial Changes

* add or force update .github/workflows/js-test-and-release.yml ([#161](#161)) ([f326cee](f326cee))
* delete templates [skip ci] ([#160](#160)) ([a0aea33](a0aea33))
* Update .github/workflows/stale.yml [skip ci] ([76cbca8](76cbca8))
* Update .github/workflows/stale.yml [skip ci] ([4285a5b](4285a5b))

### Documentation

* improve authorization docs ([5fc5592](5fc5592))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants