Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ipfs-check blog post #697

Merged
merged 9 commits into from
Oct 7, 2024
Merged

add ipfs-check blog post #697

merged 9 commits into from
Oct 7, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Sep 27, 2024

No description provided.

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 32.8%, saving 23.33 KB.

Filename Before After Improvement Visual comparison
src/assets/ipfs-check-network.png 71.07 KB 47.73 KB -32.8% View diff

593 images did not require optimisation.

@2color 2color requested a review from lidel September 27, 2024 12:49
@2color 2color requested a review from mishmosh September 27, 2024 13:04
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for amplifying this @2color! lgtm, cosmetics inline, merge when you want

src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mishmosh mishmosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions to simplify wording or turn longer paragraphs into lists, for easier scanning. None are blocking, merge when ready.

src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
2color and others added 2 commits September 30, 2024 11:25
@2color
Copy link
Member Author

2color commented Sep 30, 2024

I'm blocking publishing until we address ipfs/ipfs-check#70

src/_blog/ipfs-check.md Outdated Show resolved Hide resolved
@2color
Copy link
Member Author

2color commented Oct 7, 2024

We deployed a fix to the issue I mentioned. So this is good to go.

@2color 2color merged commit 40a0585 into main Oct 7, 2024
3 checks passed
@2color 2color deleted the ipfs-check-post branch October 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants