Improve memory usage #110
Merged
Improve memory usage #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Nov 2, 2020
| @@ -346,12 +347,19 @@ func (gsm *graphSyncMessage) ToProto() (*pb.Message, error) { | |||
| } | |||
|
|
|||
| func (gsm *graphSyncMessage) ToNet(w io.Writer) error { | |||
| pbw := ggio.NewDelimitedWriter(w) | |||
There was a problem hiding this comment.
You could also consider pooling the writers. That's what we do in the DHT.
Although this also works and is quite clean.
| @@ -55,7 +59,11 @@ func (ubs *UnverifiedBlockStore) VerifyBlock(lnk ipld.Link) ([]byte, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| _, err = buffer.Write(data) | |||
| if settable, ok := buffer.(settableWriter); ok { | |||
There was a problem hiding this comment.
This may be a bit too evil, but...
if buf, ok := buffer.(*bytes.Buffer); ok {
*buf = *bytes.NewBuffer(data)
} else {
buffer.Write(data)
}
reduce copies of temporary buffers in message write and unverified block store
hannahhoward
force-pushed
the
feat/memory-improvements
branch
from
55ed84a to
d082f38
Compare
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
docs(CHANGELOG): update for v1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Remove some unneccesary mem copies identified in testing. Specifically:
Implementation
go-ipld-primeStorer interface has an unneccesary copy of block bytes due to the need to create a bytes.Buffer to mimic an io.Writer. This creates a shortcut around that and implements it by default for the StorerFromBlockstore method