Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error if batch not committed or canceled #108

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Log error if batch not committed or canceled #108

merged 1 commit into from
Oct 9, 2020

Conversation

gammazero
Copy link
Contributor

  • Clear finalizer after successful flush or cancel.
  • Log error if finalizer is called. This informs developers if a batch has not been committed or canceled, leading to resources being held by an incomplete transaction.

@gammazero gammazero requested a review from Stebalien October 9, 2020 22:22
@Stebalien Stebalien merged commit 22c5a17 into master Oct 9, 2020
@Stebalien Stebalien deleted the chore/log-finalizer branch October 9, 2020 22:48
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gammazero @Stebalien