Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dependency check in esm modules #869

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

achingbrain
Copy link
Member

Auto-detect type: "module" in a project's package.json and switch
detective implementation to detective-es6 which understands import.

Auto-detect `type: "module"` in a project's `package.json` and switch
`detective` implementation to `detective-es6` which understands `import`.
@achingbrain achingbrain force-pushed the feat/support-dep-check-in-esm-projects branch from dad70c1 to 96199d3 Compare July 29, 2021 11:55
@achingbrain
Copy link
Member Author

achingbrain commented Jul 29, 2021

Also: we don't need to use the dependency-check fork any more, though I've switched it out for a pre-release version, so we'll need to come back and change it when it hits v5 for reals.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM

@achingbrain achingbrain requested a review from vasco-santos July 29, 2021 13:52
@achingbrain achingbrain merged commit 48712b1 into master Jul 29, 2021
@achingbrain achingbrain deleted the feat/support-dep-check-in-esm-projects branch July 29, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants