Redo gconf #503
Merged
Redo gconf #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is one test failing that I cannot figure out. I have spend a lot of time on fixing tests and I cannot figure this one out. |
|
Closed in favour of https://github.com/iov-one/weave/compare/gconf_alex_spike?expand=1 |
ethanfrey
reviewed
Apr 16, 2019
|
I'm reopening this one, as I used it as a basis for my new pr #534 Let's get this done |
This was referenced Apr 17, 2019
This comment has been minimized.
This comment has been minimized.
Cleanup `gconf` package configuration. Instead of allowing for any key-value pairs inserted into gconf store, require each module to use a custom protobuf configuration object that will be stored and retrieved with the help of `gconf` package. resolve #456
- enhance error messages - move message code to `msg.go` - move handler code to `handlers.go` - register configuration handler together with other message handlers
husio
force-pushed
the
cleanup_gconf_2_issue_456
branch
from
aff60d3 to
4fe62e9
Compare
|
I think this is ready. @alpe @ethanfrey please review it again. 🤞 |
|
Will review now |
ethanfrey
approved these changes
Apr 18, 2019
| // message must be signed by an owner in order to be authorized to apply the | ||
| // change. | ||
| type OwnedConfig interface { | ||
| Unmarshaler |
There was a problem hiding this comment.
I think referring to Configuration here is cleaner. It shows we extend the Configuration interface with one more method
|
🎉 |
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup
gconfpackage configuration.Instead of allowing for any key-value pairs inserted into gconf store,
require each module to use a custom protobuf configuration object that
will be stored and retrieved with the help of
gconfpackage.resolve #456