Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for elements/molecules don't display in HQM quest book. #431

Closed
Mechalith opened this issue Nov 11, 2014 · 6 comments
Closed

Icons for elements/molecules don't display in HQM quest book. #431

Mechalith opened this issue Nov 11, 2014 · 6 comments

Comments

@Mechalith
Copy link

Not certain this is the cause, but Minechem is the only mod I've seen with an issue, and it's also the only one that uses index colors rather than RGB for it's icons and textures. I suspect changing to the RGB color space will correct the issue but haven't been able to test. (Adding this at Jakimfett's request.)

@jakimfett
Copy link
Collaborator

Per our conversation on Reddit:

@hilburn
Copy link
Contributor

hilburn commented Nov 11, 2014

It's an interesting theory.. So loading up the icons in PS and re-saving them might fix this?
Element colours are set with this function
And Molecule colours are set in one of these two functions when the molecule is created - the RenderItemIntoGUI seems to work identically to everything else I've played with so I don't think it's a rendering issue on our end, unless HQM try to render it with an odd rendertype because in that case I think we default to not rendering.

To test your theory, would you mind checking out TiC tool parts? as TiC tools made of more that one item do not render either.

Of course a third option is that we might be rendering our items too low, so they render behind the book.. that would be interesting

@Mechalith
Copy link
Author

I actually looked at the image layers, which seemed fine, so I don't think that's it unless you're setting a layer of some sort in the actual code. Will check TiC, report findings. Any specific pieces, or just whole tools?

@Mechalith
Copy link
Author

Is there any possibility that HQM is just grabbing the icon data and not being able to parse the process needed to color it? I'm still getting Photoshop set up on this system so I haven't checked the color space in the TiCon parts, but the non-static item icon is something that both affected mods have in common.

@hilburn
Copy link
Contributor

hilburn commented Nov 11, 2014

The RenderItemInInventory method we use is fairly standard and is (from what I can tell) what HQM uses to render the Item in the book.
Luckily for all involved @way2muchnoise is looking at this now who is much better with render issues than me

@way2muchnoise
Copy link
Contributor

Kinda fixed stuff in #432 just the text saying like H on element renders wrong. I still think HQM could do more about it then we can do. But for now it is fixed (except for the text)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants