Remote NetCDF TableDAP #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues an HTTP HEAD request and handles "Content-Type: application/x-netcdf" headers by attempting to open a netCDF file in memory. Opening in memory will require the netCDF-C library to be compiled with that feature.
Use the content-type request header to inform how a dataset should be created. Remote NetCDF resources can be created via fetching the raw bytes and instantiating a MemoizedDataset object. Extend this capability to fetch TableDAP datasets by simply adding the .ncCF extension and the string of variables to the dataset URL.
|
Good call @benjwadams, I'll implement that |
Use a try-catch routine to first attempt creating an in-memory netCDF4-python Dataset. If the netcdf-c lib was compiled without in-memory options, an OSError will be thrown; this is excepted and a NamedTemporaryFile is used to hold the raw bytes.
benjwadams
reviewed
May 4, 2020
| timeout=60) | ||
| try: | ||
| return MemoizedDataset(response.content, memory=response.content) | ||
| except OSError as e: |
benjwadams
approved these changes
May 4, 2020
benjwadams
reviewed
May 4, 2020
| @@ -20,3 +23,30 @@ class MemoizedDataset(Dataset): | |||
| @lru_cache(128) | |||
| def get_variables_by_attributes(self, **kwargs): | |||
| return super(MemoizedDataset, self).get_variables_by_attributes(**kwargs) | |||
|
|
|||
| @contextmanager | |||
| def tempnc(data: BinaryIO) -> Generator[str, None, None]: | |||
There was a problem hiding this comment.
Maybe rename this to create_temporary_ncfile or something more explicit.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take elements of #799 and #800 to fetch remote NetCDF resources and uses this capability to fetch ERDDAP TableDAP datasets with the .ncCF extension.