Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompileItem metadata to types #213

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Smaug123
Copy link
Contributor

@Smaug123 Smaug123 commented Oct 2, 2024

I'm looking at writing something Myriad-like which also has access to the typed AST and other such compiler information, and it would really help if I could pick up configuration from the project file. Myriad itself does this directly in MsBuild rules, but I would like to program in a language that is not MsBuild-flavoured XML, so I'd like to use proj-info to get the build graph and work out what I need to generate.

@Smaug123 Smaug123 force-pushed the add-compile-metadata branch from 1dc8bde to 2aa22c4 Compare October 2, 2024 18:34
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is there a way to add this to a test so we don't regress?

@Smaug123
Copy link
Contributor Author

Smaug123 commented Oct 2, 2024

Yes, although I would prefer to wait for #212 if I'm going to add tests.

@TheAngryByrd TheAngryByrd merged commit f789e71 into ionide:main Oct 2, 2024
9 checks passed
@Smaug123 Smaug123 deleted the add-compile-metadata branch October 2, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants