Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support projects running on .NET 7 #167

Merged
merged 21 commits into from
Aug 21, 2022
Merged

Support projects running on .NET 7 #167

merged 21 commits into from
Aug 21, 2022

Conversation

baronfel
Copy link
Collaborator

No description provided.

Comment on lines +56 to +81
"inputs": [
{
"id": "tfm",
"description": "The TFM of the test to run",
"options": [
"net6.0",
"net7.0"
],
"default": "net7.0",
"type": "pickString"
},
{
"id": "loader",
"description": "The loader to use for the test",
"options": [
"WorkspaceLoader",
"WorkspaceLoaderViaProjectGraph"
],
"default": "WorkspaceLoader",
"type": "pickString"
},
{
"id": "testName",
"description": "the name of the test as provided to `testCase`",
"type": "promptString"
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so handy - now you get a couple drop-downs when you go to run specific tests that make it easier to run just one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still need the 'base' test name, but since the loader and TFM are the most annoying parts to form up, this is still super helpful IMO

@baronfel
Copy link
Collaborator Author

So in the end there aren't many changes made to the actual code of this project - the build pipelines now explicitly test net7.0 loading and they do so by making the tests project multitarget. there's a very minor change to the matching code for graph builds due to an internal change there, but the majority of things Just Work on 7 as long as you run it from a 7 context. We'll likely need to do similar things when we test in FSAC - at least with relation to the CI build. We might not need to make all of FSAC 7-aware as long as rollforward is enabled. We;ll find out in a bit I guess.

@baronfel baronfel merged commit 449b9c6 into main Aug 21, 2022
@baronfel baronfel deleted the net7-support branch August 21, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants