-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making ProjectGraphLoader work again #165
Conversation
d806e8f
to
aae4a7a
Compare
aae4a7a
to
4ac01dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self code review
let parsedC1 = parsed |> Seq.find(fun x -> | ||
x.ProjectFileName.EndsWith(``sample3 Netsdk projs``.ProjectFile) | ||
) | ||
let fcsPo = FCS.mapToFSharpProjectOptions parsedC1 parsed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't guarantee order so have to find our console app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense 👍
|
||
printfn "%A" parsed | ||
let slnPath = @"C:\Users\JimmyByrd\Documents\Repositories\public\TheAngryByrd\FsToolkit.ErrorHandling\FsToolkit.ErrorHandling.sln" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, this test is a scratch-pad for folks anyway so I don't think the content is really special
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
let parsedC1 = parsed |> Seq.find(fun x -> | ||
x.ProjectFileName.EndsWith(``sample3 Netsdk projs``.ProjectFile) | ||
) | ||
let fcsPo = FCS.mapToFSharpProjectOptions parsedC1 parsed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense 👍
|
||
printfn "%A" parsed | ||
let slnPath = @"C:\Users\JimmyByrd\Documents\Repositories\public\TheAngryByrd\FsToolkit.ErrorHandling\FsToolkit.ErrorHandling.sln" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, this test is a scratch-pad for folks anyway so I don't think the content is really special
No description provided.