Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making ProjectGraphLoader work again #165

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Aug 20, 2022

No description provided.

@TheAngryByrd TheAngryByrd force-pushed the fixing-graph-issues-again branch 3 times, most recently from d806e8f to aae4a7a Compare August 20, 2022 17:36
@TheAngryByrd TheAngryByrd marked this pull request as ready for review August 20, 2022 17:36
@TheAngryByrd TheAngryByrd force-pushed the fixing-graph-issues-again branch from aae4a7a to 4ac01dc Compare August 20, 2022 17:40
Copy link
Member Author

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self code review

let parsedC1 = parsed |> Seq.find(fun x ->
x.ProjectFileName.EndsWith(``sample3 Netsdk projs``.ProjectFile)
)
let fcsPo = FCS.mapToFSharpProjectOptions parsedC1 parsed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't guarantee order so have to find our console app

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense 👍


printfn "%A" parsed
let slnPath = @"C:\Users\JimmyByrd\Documents\Repositories\public\TheAngryByrd\FsToolkit.ErrorHandling\FsToolkit.ErrorHandling.sln"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could revert

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, this test is a scratch-pad for folks anyway so I don't think the content is really special

Copy link
Collaborator

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

let parsedC1 = parsed |> Seq.find(fun x ->
x.ProjectFileName.EndsWith(``sample3 Netsdk projs``.ProjectFile)
)
let fcsPo = FCS.mapToFSharpProjectOptions parsedC1 parsed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense 👍


printfn "%A" parsed
let slnPath = @"C:\Users\JimmyByrd\Documents\Repositories\public\TheAngryByrd\FsToolkit.ErrorHandling\FsToolkit.ErrorHandling.sln"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, this test is a scratch-pad for folks anyway so I don't think the content is really special

@baronfel baronfel merged commit 1a4adda into ionide:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants