Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify getting the build projects from the GraphBuildResult. #144

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Apr 7, 2022

I'm currently tinkering with a large solution (300+ projects) and this bit wasn't resolving for me.
@TheAngryByrd I believe this yields the same result, what do you think?

@TheAngryByrd
Copy link
Member

This looks a lot more simple! No idea what I was smoking when I wrote this.

@baronfel
Copy link
Collaborator

baronfel commented Apr 7, 2022

Are the graph loader tests enabled at the moment? not sure off the top of my head

@nojaf
Copy link
Contributor Author

nojaf commented Apr 7, 2022

No, they don't appear to be.

@baronfel
Copy link
Collaborator

baronfel commented Apr 7, 2022

Could you try turning them on before we merge this? I'd appreciate the coverage for my own sanity 😂

@nojaf
Copy link
Contributor Author

nojaf commented Apr 7, 2022

Yeah, just tried them, they failed on my local main branch.
I did notice something weird where the options of a referenced project are empty, while they are not for non-graph.

@baronfel
Copy link
Collaborator

Thanks for this! We can look at reenabling graph build tests as a next step.

@baronfel baronfel merged commit f17dcc5 into ionide:main Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants