Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow global properties to be provided to project loaders #107

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Allow global properties to be provided to project loaders #107

merged 4 commits into from
Apr 16, 2021

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Apr 13, 2021

See #106

@dsyme dsyme mentioned this pull request Apr 13, 2021
Merged
@dsyme
Copy link
Contributor Author

dsyme commented Apr 13, 2021

OK this is ready :-)

@dsyme
Copy link
Contributor Author

dsyme commented Apr 14, 2021 •
edited
Loading

If this could be merged and a new package published that would be great, as it will unblock fsprojects/FSharp.Formatting#663, thanks

@dsyme
Copy link
Contributor Author

dsyme commented Apr 14, 2021

Just to mention that in fsprojects/FSharp.Formatting#663 I took a temporary local copy of the Ionide.ProjInfo files pending the integration+publish of this

thanks! :-)

@baronfel
Copy link
Collaborator

Thanks for this!

@baronfel baronfel merged commit d9b0b7b into ionide:master Apr 16, 2021
@baronfel
Copy link
Collaborator

Package 0.52.0 has been pushed to Nuget.

@dsyme
Copy link
Contributor Author

dsyme commented Apr 16, 2021

Thank you @baronfel !!

@baronfel baronfel mentioned this pull request Apr 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsyme @baronfel