Add EnclosingEntity and IsAbstract to Declaration contract #129
Conversation
|
It's ready for merging. |
update integration tests output after updating FCS to version 8
| @@ -91,6 +91,11 @@ | |||
| <Choose> | |||
| <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.5'"> | |||
| <ItemGroup> | |||
| <Reference Include="FSharp.Compiler.Service.MSBuild.v12"> | |||
| <HintPath>..\..\packages\FSharp.Compiler.Service\lib\net45\FSharp.Compiler.Service.MSBuild.v12.dll</HintPath> | |||
There was a problem hiding this comment.
Do you have to add this DLL to your VSIX setup files?
There was a problem hiding this comment.
There is no VSIX in this project, it's just a library. However, I cannot find how the NuGet package is build and published (nothing in build.fsx)
There was a problem hiding this comment.
There is no Nuget package, I think. Only GitHub release
There was a problem hiding this comment.
Ah, ionide does not need nuget package, it just references the repository directly :)
|
@vasily-kirichenko Please keep an eye on how things stand w.r.t. MSBuild reference resolution etc. after this is integrated. |
|
I've no idea what's going on with the CIs. It builds OK on my machine. |
|
The Travis failure matches my experience running the integration tests against this PR locally on Linux. Why would FCS return different error messages on different platforms? Anyway, I am just looking at changing the test to use a user-defined symbol for which hopefully the results should be the same for both platforms. |
|
Yeah, FCS returns |
|
In this case the output seems semantically different: - "Message": "The value, constructor, namespace or type 'Directory' is not defined\r\nMaybe you want one of the following:\r\n Direct\r\n Ports\r\n Compression\r\n ErrorEventArgs\r\n NotifyFilters",
+ "Message": "The value, constructor, namespace or type 'Directory' is not defined\nMaybe you want one of the following:\n FileAction\n FileData\n Ports\n kevent\n timespec",FCS suggests different replacements for the symbol. |
|
wow |
|
@rneatherway I tried to fix the line endings here 530f09e |
|
It's not only about line endings, suggested types are different too |
|
@Krzysztof-Cieslak yes, I see. Very interesting. @forki @forki @forki |
|
A small change would remove the difference: #130 |
…claration-contract Conflicts: test/FsAutoComplete.IntegrationTests/SymbolUse/output.json
|
I've merged your change, let's see if it helps. |
|
Cool OK, I think it still bears investigation, but more at the FCS end than here. |
|
I think it's caused by new compiler error messages, so it's the compiler, not even FCS. |
|
I think I deserves merging now :) |
|
Definitely! |
|
cheers |
fsharp/fsharp-compiler-docs#650 must be merged and new FCS nuget package must be published and referenced in this PR before it's merged.