Live refresh #29
Merged
Live refresh #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @NatElkins, sorry for delay. This looks good to me in general. Can you rebase it to latest master? |
|
@Krzysztof-Cieslak This is now rebased to master, and I've verified that the exit code changes are functioning as expected. That WebSocket error log message is still there, although it doesn't affect the functionality at all. Is it fine for it to be there? |
|
Yeah, don't worry about the log messages, it's not critical. Thanks a lot, it looks amazing ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds live refresh to the
fornax watchcommand. It can be disabled viafornax watch --disable-live-refresh.Sorry the gif is so tiny, it's the biggest one I could upload.
How to test:
cd src/Fornax./resetTool.shmkdir testcd testfornax newfornax watch*.mdfiles.There's only one annoying thing left, it's not really a big deal but I'm not sure how to get rid of it. When the page reloads, Suave outputs the following message:
I'm sure there's a way to get rid of it, I'm just not sure how.
Let me know if any changes should be made.