Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Extensions.Logging.Console to 6.0.1 #224

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Nov 20, 2024

When I was doing G-Research/fsharp-analyzers#85 I got a security warning from Visual Studio about a transitive dependency

FSharp.Analyzers.SDK.Testing -> Microsoft.Extensions.Logging.Console -> System.Text.Json 6.0.0

Because System.Text.Json 6.0.0 has known CVEs.

So I wondered if it would be useful to update Microsoft.Extensions.Logging.Console to 6.0.1, which has removed the NuGet dependency on System.Text.Json in the .NET 6.0 TFM so it just uses the in-box version.

This shouldn't effect the version of Microsoft.Extensions.Logging.Abstractions used by the SDK lib itself, just the console lib used by the Testing and Cli packages.

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@nojaf nojaf merged commit ac7d475 into ionide:main Nov 20, 2024
2 checks passed
@Numpsy Numpsy deleted the bump-console branch November 20, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants