Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the path to the binlog in quotes when building a test project #169

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Nov 22, 2023

I was having a go at building the SDK locally to test some things, and the build script failed to run the tests with errors like

MSBuild version 17.8.3+195e7f5a3 for .NET
MSBUILD : error MSB1009: Project file does not exist.
Switch: Webb\AppData\Local\Temp\FSharp.Analyzers.SDK.BinLogCache\v0.21.0.0_net7.0_Newtonsoft.Json_13.0.3_Fantomas.FCS_6.2.0.binlog

StdErr:

Exception:
CliWrap.Exceptions.CommandExecutionException: Command execution failed because the underlying process (dotnet.exe#12396) returned a non-zero exit code (1).

Command:
dotnet build -bl:C:\Users\Richard Webb\AppData\Local\Temp\FSharp.Analyzers.SDK.BinLogCache\v0.21.0.0_net7.0_Newtonsoft.Json_13.0.3_Fantomas.FCS_6.2.0.binlog

As it happens, the path to my user/temp directory has a space in it, and the Switch: Webb\AppData\Local\ made it look like it wasn't coping with that.

This change appears to be enough to get the command line build to complete.

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nojaf nojaf merged commit 9a71b32 into ionide:master Nov 23, 2023
2 checks passed
@Numpsy Numpsy deleted the quote_binlog_path branch November 23, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants