#6228 [enhancement]: Outline error nodes in red #7444
+43
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a red box shadow ("outline") to nodes that have missing required inputs or execution errors. Addresses issue #6228
Key Changes
Error State Tracking:
isErrorNode
andfieldErrors
to theInvocationNodeData
type for tracking the overall error state of a node and specific errors for individual inputs.fieldErrors
andisErrorNode
in the node's data when an input field becomes valid/invalid.Visual Feedback for Error Nodes:
I added a red outline at first, but that disappeared when zoomed out, making this feature useless for large workflows.
Instead I opted to use a box shadow which remained visible even when zoomed out very far.
State Initialization:
buildInvocationNode
,graphToWorkflow
) to include default values forisErrorNode
andfieldErrors
.validateWorkflow.test.ts
) to account for the new fields.Behavior:
Testing: