Turn deps into weakdeps #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 14 16 +2
Lines 688 688
=======================================
Hits 652 652
Misses 36 36 ☔ View full report in Codecov by Sentry. |
|
I see no downsides, thanks for doing this. I re-enabled CI, maybe we should disable it from running nightly though as that's a lot... if nobody is looking for months. But not this PR's problem. Can you bump the version in Project.toml? |
mcabbott
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #217.
deps -> weakdeps: AbstractFFTs, ChainRulesCore, CovarianceEstimation
requires -> weakdeps: Tracker
Tests (should) pass on both 1.6 and 1.9. Failures on 1.10 unrelated: there's a known Julia issue with new ambiguities JuliaLang/julia#52386 JuliaLang/julia#52263 JuliaSparse/SparseArrays.jl#431.