Merge pull request #817 from introlab/813-make-rtabmap_ros_install_pr…

…efix-relative-to-current-install-directory Using upstream rtabmap cmake targets
introlab · Feb 13, 2023 · 7c202de · 7c202de
2 parents 46c2988 + bbc4e59
commit 7c202de
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 50 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -32,16 +32,9 @@ find_package(fiducial_msgs)
 
 ## System dependencies are found with CMake's conventions
 # find_package(Boost REQUIRED COMPONENTS system)
-find_package(RTABMap 0.20.23 REQUIRED)
+find_package(RTABMap 0.21.0 REQUIRED)
 
-find_package(OpenCV REQUIRED QUIET COMPONENTS core calib3d imgproc highgui stitching photo video OPTIONAL_COMPONENTS aruco xfeatures2d nonfree gpu cudafeatures2d)
-
-IF(RTABMAP_GUI)
-FIND_PACKAGE(PCL 1.7 REQUIRED QUIET COMPONENTS common io kdtree search surface filters registration sample_consensus segmentation visualization)
-ELSE()
-FIND_PACKAGE(PCL 1.7 REQUIRED QUIET COMPONENTS common io kdtree search surface filters registration sample_consensus segmentation )
-ENDIF()
-add_definitions(${PCL_DEFINITIONS}) # To include -march=native if set
+add_definitions(${RTABMap_DEFINITIONS}) # To include -march=native if set
 
 IF(WIN32)
 add_compile_options(-bigobj)
@@ -71,27 +64,6 @@ IF(RTABMAP_SYNC_USER_DATA)
 add_definitions("-DRTABMAP_SYNC_USER_DATA")
 ENDIF(RTABMAP_SYNC_USER_DATA)
 
-#Qt stuff
-# If librtabmap_gui.so is found, rtabmapviz will be built
-# If rviz is found, plugins will be built
-IF(RTABMAP_GUI OR rviz_FOUND)
-   IF(RTABMAP_QT_VERSION EQUAL 4)
-      FIND_PACKAGE(Qt4 COMPONENTS QtCore QtGui REQUIRED)
-      INCLUDE(${QT_USE_FILE})
-   ELSE()
-      IF(RTABMAP_GUI)
-         FIND_PACKAGE(Qt5 COMPONENTS Widgets Core Gui REQUIRED)
-      ELSE()
-         # For rviz plugins, look for Qt5 before Qt4
-         FIND_PACKAGE(Qt5 COMPONENTS Widgets Core Gui QUIET)
-         IF(NOT Qt5_FOUND)
-            FIND_PACKAGE(Qt4 COMPONENTS QtCore QtGui REQUIRED)
-            INCLUDE(${QT_USE_FILE})
-         ENDIF(NOT Qt5_FOUND)
-      ENDIF()
-   ENDIF()   
-ENDIF(RTABMAP_GUI OR rviz_FOUND)
-
 ## Uncomment this if the package has a setup.py. This macro ensures
 ## modules and global scripts declared therein get installed
 ## See http://ros.org/doc/api/catkin/html/user_guide/setup_dot_py.html
@@ -184,12 +156,12 @@ ENDIF(find_object_2d_FOUND)
 
 catkin_package(
   INCLUDE_DIRS include
-  LIBRARIES rtabmap_ros
+  LIBRARIES rtabmap_ros rtabmap_sync
   CATKIN_DEPENDS cv_bridge roscpp rospy sensor_msgs std_msgs std_srvs nav_msgs geometry_msgs visualization_msgs
                  image_transport tf tf_conversions tf2_ros eigen_conversions laser_geometry pcl_conversions 
                  pcl_ros nodelet dynamic_reconfigure message_filters class_loader rosgraph_msgs
                  stereo_msgs move_base_msgs image_geometry ${optional_dependencies}
-  DEPENDS RTABMap OpenCV
+  DEPENDS RTABMap
 )
 
 ###########
@@ -201,18 +173,13 @@ catkin_package(
 # include_directories(include)
 include_directories(
   ${CMAKE_CURRENT_SOURCE_DIR}/include
-  ${RTABMap_INCLUDE_DIRS}
-  ${OpenCV_INCLUDE_DIRS}
-  ${PCL_INCLUDE_DIRS}
   ${catkin_INCLUDE_DIRS}
 )
 
 # libraries
 SET(Libraries
-   ${OpenCV_LIBRARIES}
-   ${PCL_LIBRARIES}
+   rtabmap
    ${catkin_LIBRARIES}
-   ${RTABMap_LIBRARIES}
 )
 
 SET(rtabmap_sync_lib_src
@@ -336,8 +303,9 @@ target_link_libraries(rtabmap_plugins
 add_dependencies(rtabmap_ros ${${PROJECT_NAME}_EXPORTED_TARGETS})
 add_dependencies(rtabmap_plugins ${${PROJECT_NAME}_EXPORTED_TARGETS})
 
-add_executable(rtabmap src/CoreNode.cpp)
-target_link_libraries(rtabmap ${Libraries})
+add_executable(rtabmap_node src/CoreNode.cpp)
+target_link_libraries(rtabmap_node ${Libraries})
+set_target_properties(rtabmap_node PROPERTIES OUTPUT_NAME "rtabmap")
 
 add_executable(rtabmap_rgbd_odometry src/RGBDOdometryNode.cpp)
 target_link_libraries(rtabmap_rgbd_odometry ${Libraries})
@@ -426,12 +394,9 @@ add_executable(rtabmap_stereo_camera src/StereoCameraNode.cpp)
 target_link_libraries(rtabmap_stereo_camera rtabmap_ros)
 set_target_properties(rtabmap_stereo_camera PROPERTIES OUTPUT_NAME "stereo_camera")
 
-IF(RTABMAP_GUI)
+IF(RTABMap_gui_FOUND)
     add_executable(rtabmapviz src/GuiNode.cpp src/GuiWrapper.cpp src/PreferencesDialogROS.cpp)
-    target_link_libraries(rtabmapviz rtabmap_sync ${QT_LIBRARIES})
-    IF(Qt5_FOUND)
-        QT5_USE_MODULES(rtabmapviz Widgets Core Gui)
-    ENDIF()
+    target_link_libraries(rtabmapviz rtabmap_sync rtabmap_gui)
 ELSE()
     MESSAGE(WARNING "Found RTAB-Map built without its GUI library. Node rtabmapviz will not be built!")
 ENDIF()
@@ -599,7 +564,7 @@ install(TARGETS
    rtabmap_sync
    rtabmap_ros
    rtabmap_plugins 
-   rtabmap 
+   rtabmap_node 
    rtabmap_rgbd_odometry 
    rtabmap_icp_odometry
    rtabmap_rgbdicp_odometry 
@@ -620,14 +585,14 @@ install(TARGETS
    LIBRARY DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}
    RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}
 )
-IF(RTABMAP_GUI)
+IF(RTABMap_gui_FOUND)
     install(TARGETS 
        rtabmapviz
        ARCHIVE DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}
        LIBRARY DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}
        RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}
      )
-ENDIF(RTABMAP_GUI)
+ENDIF(RTABMap_gui_FOUND)
 
 ## Mark cpp header files for installation
 install(DIRECTORY include/${PROJECT_NAME}/

diff --git a/include/rtabmap_ros/MapsManager.h b/include/rtabmap_ros/MapsManager.h
@@ -43,6 +43,8 @@ class OccupancyGrid;
 
 }  // namespace rtabmap
 
+namespace rtabmap_ros {
+
 class MapsManager {
 public:
 	MapsManager();
@@ -136,4 +138,6 @@ class MapsManager {
 	std::map<void*, bool> latched_;
 };
 
+}  // namespace rtabmap_ros
+
 #endif /* MAPSMANAGER_H_ */
diff --git a/package.xml b/package.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <package format="2">
   <name>rtabmap_ros</name>
-  <version>0.20.23</version>
+  <version>0.21.0</version>
   <description>RTAB-Map's ros-pkg. RTAB-Map is a RGB-D SLAM approach with real-time constraints.</description>
   <maintainer email="[email protected]">Mathieu Labbe</maintainer>
   <author>Mathieu Labbe</author>

diff --git a/src/MapAssemblerNode.cpp b/src/MapAssemblerNode.cpp
@@ -342,7 +342,7 @@ class MapAssembler
 #endif
 
 private:
-	MapsManager mapsManager_;
+	rtabmap_ros::MapsManager mapsManager_;
 	std::map<int, Signature> nodes_;
 	std::map<int, Transform> optimizedPoses_;
 	std::string mapFrameId_;

diff --git a/src/MapsManager.cpp b/src/MapsManager.cpp
@@ -56,6 +56,8 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 using namespace rtabmap;
 
+namespace rtabmap_ros {
+
 MapsManager::MapsManager() :
 		cloudOutputVoxelized_(true),
 		cloudSubtractFiltering_(false),
@@ -1557,3 +1559,5 @@ cv::Mat MapsManager::getGridProbMap(
 	return occupancyGrid_->getProbMap(xMin, yMin);
 }
 
+}  // namespace rtabmap_ros
+