Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring RTABMapConfig.cmake with targets #904

Merged
merged 12 commits into from
Feb 13, 2023
Merged

Refactoring RTABMapConfig.cmake with targets #904

merged 12 commits into from
Feb 13, 2023

Conversation

matlabbe
Copy link
Member

@matlabbe matlabbe commented Sep 26, 2022 •
edited
Loading

  • Test with external project
  • Test with external ros project
  • Test with external ros2 project
  • Test on Ubuntu 18.04
  • Test on Ubuntu 20.04
  • Test on Ubuntu 22.04
  • Test on Windows
  • Test with external project on Windows

ros updated branch: introlab/rtabmap_ros#817
ros2 updated branch: introlab/rtabmap_ros#885

@matlabbe matlabbe linked an issue Sep 26, 2022 that may be closed by this pull request
Refactor RTABMapConfig.cmake to use targets #903
Closed
@matlabbe matlabbe changed the title Config: Using cmake targets Refactoring RTABMapConfig.cmake with targets Sep 26, 2022
@matlabbe matlabbe mentioned this pull request Sep 26, 2022
Closed
@matlabbe matlabbe marked this pull request as draft September 26, 2022 06:10
@matlabbe matlabbe marked this pull request as ready for review February 12, 2023 23:01
@matlabbe matlabbe merged commit 89e3e10 into master Feb 13, 2023
@matlabbe matlabbe deleted the 903-refactor-rtabmapconfigcmake-to-use-targets branch February 13, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor RTABMapConfig.cmake to use targets
1 participant
@matlabbe