List dependencies only once #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added |
|
Perfect thx! For libopenni2-dev, I'll see next time I do push ros binaries. |
|
Hi @matlabbe do you have an estimate on when that would be? Compiling takes a long time, and I'm willing to test out the ros-testing binaries as soon as you bloomed them to see if the dependencies propagate properly. |
|
melodic/noetic released soon! |
|
Great thanks 👍 |
|
Oh I didn't see libpointmatcher on ros2 too. I'll check this later (would require a merge between master and ros2 branch for rtabmap_ros). |
|
Looks like they didn't like my latest pull requests, I'll need to redo melodic and noetic too! |
|
They merged the new pull requests. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept the comments.
Seems like
libopenni2-devis available on all platforms these days?