-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add color flag #339
add color flag #339
Conversation
Signed-off-by: Vivek Kumar Sahu <[email protected]>
9d6d681
to
8910485
Compare
Signed-off-by: Vivek Kumar Sahu <[email protected]>
complianceCmd.Flags().BoolP("json", "j", false, "output in json format") | ||
complianceCmd.Flags().BoolP("basic", "b", false, "output in basic format") | ||
complianceCmd.Flags().BoolP("detailed", "d", false, "output in detailed format") | ||
complianceCmd.Flags().BoolP("color", "l", false, "output in colorful") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color mode on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should always default to off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our motive is to make it off until and unless explicity it is turned on via --color=true
or -l
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to make it on
or off
, by default ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, yeah that's what parameter (false) signifies to.
Add flag for color output.
go run main.go compliance -f --color=false ../lynk-api/scripts/samples/misc/ascii-boxes-sbom-cdx.json
Command help: