-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for OpenChain Telco compliance #261
add support for OpenChain Telco compliance #261
Conversation
3f1b146
to
9636f7d
Compare
9636f7d
to
7ed3d5d
Compare
Signed-off-by: Vivek Kumar Sahu <[email protected]> remove extra column Signed-off-by: Vivek Kumar Sahu <[email protected]> removed duplicate field Signed-off-by: Vivek Kumar Sahu <[email protected]> lite version of oct compliance implementation Signed-off-by: Vivek Kumar Sahu <[email protected]> add opentelco compliance for sbom specification Signed-off-by: Vivek Kumar Sahu <[email protected]> update compliance readme Signed-off-by: Vivek Kumar Sahu <[email protected]> replace "name" datafield by "specType" Signed-off-by: Vivek Kumar Sahu <[email protected]> add oct compliance for componenets Signed-off-by: Vivek Kumar Sahu <[email protected]> complete readme for openchain telco compliance Signed-off-by: Vivek Kumar Sahu <[email protected]> added section ID column Signed-off-by: Vivek Kumar Sahu <[email protected]> add compliance for other data fields Signed-off-by: Vivek Kumar Sahu <[email protected]> handle cyclonedx sbom for oct Signed-off-by: Vivek Kumar Sahu <[email protected]> add externalRef datafield for oct compliance Signed-off-by: Vivek Kumar Sahu <[email protected]> remove unwanted print stmt Signed-off-by: Vivek Kumar Sahu <[email protected]> handle exception Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
Signed-off-by: Vivek Kumar Sahu <[email protected]>
6e34ad1
to
70ee307
Compare
Signed-off-by: Vivek Kumar Sahu <[email protected]>
ae249a5
to
ef301ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks very good great work.
## OpenChain Telco: SBOM Requirements for OCT | ||
|
||
The [OpenChain Telco](https://github.com/OpenChain-Project/Reference-Material/blob/master/SBOM-Quality/Version-1/OpenChain-Telco-SBOM-Guide_EN.md) specifies mandatory properties for an SBOM. Below is how we have derived all the values. | ||
| OpenTelco | Section ID | OpenTelco field | SPDX(2.3) | Notes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all the details in () not required. e.g DataLicense(SBOM_LICENSE) we don't require (SBOM_LICENSE)
@@ -57,5 +61,13 @@ func ComplianceResult(ctx context.Context, doc sbom.Document, reportType, fileNa | |||
ntiaResult(ctx, doc, fileName, outFormat) | |||
} | |||
|
|||
if reportType == OCT_TELCO { | |||
if doc.Spec().GetSpecType() != "spdx" { | |||
fmt.Println("The Provided SBOM spec is other than SPDX. Open Chain Telco only support SPDX specs SBOMs.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Vivek Kumar Sahu <[email protected]>
This PR will contain feature for Open Telco SBOM compliance:
sbomqs compliance <sbom_file> --oct
will look like: https://gist.github.com/viveksahu26/07a0c568beb9b31dbb813d3785507acaDescription of this PR:
compliance
sub-command for OpenChain Telco SBOMs standards.referenceType
i.e.purl
must be present. UnderexternalRefs
there are list of reference with 3 fieldcategory type
,package manager
andlocator
. There is bit a different way of scoring it. Suppose - out of 5 list of references, only 2 reference containspurl
, then score would be like: (2/5)*10 = 4.