Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation fixes #159

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Documentation fixes #159

merged 1 commit into from
Aug 5, 2024

Conversation

yixuan
Copy link
Contributor

@yixuan yixuan commented Jul 26, 2024

This pull request fixes some mistakes in the previous documentation, and reflects recent API changes.

  1. AVX2 now also has argsort, argselect, and key-value sort.
  2. Adds the missing argument k in qselect and partial_qsort.
  3. The version of argsort that returns a std::vector has been removed. Similar for argselect.
  4. Fixes the template parameters in avx512_qsort_kv.
  5. The sample code needs to include some xss-common-* headers to compile.

r-devulap
r-devulap approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@r-devulap r-devulap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing!

@r-devulap r-devulap merged commit 87486d1 into intel:main Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-devulap r-devulap r-devulap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yixuan @r-devulap