Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling after wasm-pack update #118

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Fix error handling after wasm-pack update #118

merged 1 commit into from
Jun 19, 2023

Conversation

50U10FCA7
Copy link
Contributor

@50U10FCA7 50U10FCA7 commented Jun 16, 2023 •
edited
Loading

Error handling in medea-e2e relying on fact the wasm-pack objects are marked with ptr field, but it was renamed to __wbg_ptr in rustwasm/wasm-bindgen#3408

@50U10FCA7 50U10FCA7 added the enhancement Improvement of existing features or bugfix label Jun 16, 2023
@50U10FCA7 50U10FCA7 self-assigned this Jun 16, 2023
@50U10FCA7 50U10FCA7 added k::api Related to API (application interface) platform::web Specific to WEB platform labels Jun 16, 2023
@50U10FCA7 50U10FCA7 requested a review from tyranron June 16, 2023 18:59
@50U10FCA7
Copy link
Contributor Author

50U10FCA7 commented Jun 16, 2023 •
edited by tyranron
Loading

FCM

Fix `browser::Client` WASM errors handling in `medea-e2e` crate (#118)

@tyranron tyranron added the k::testing Related to testing and/or automated tests label Jun 19, 2023
@tyranron tyranron merged commit 5667cfb into master Jun 19, 2023
@tyranron tyranron deleted the fix-error-handling branch June 19, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@50U10FCA7 50U10FCA7

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::testing Related to testing and/or automated tests platform::web Specific to WEB platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@50U10FCA7 @tyranron